Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soroban-cli: wrap token fails with valid inputs in sandbox mode #936

Merged
merged 2 commits into from
Sep 7, 2023
Merged

soroban-cli: wrap token fails with valid inputs in sandbox mode #936

merged 2 commits into from
Sep 7, 2023

Conversation

tsachiherman
Copy link
Contributor

@tsachiherman tsachiherman commented Sep 7, 2023 •
edited
Loading

What version are you using?

9615897

❯ soroban version
soroban 0.9.4 (v0.9.5-70-g9615897821492671f951169f8f442d69cafb3d81)
soroban-env 0.0.17 (eb5a9ba053a7b64a8eff605db625525378f7bea0)
soroban-env interface version 85899345977
stellar-xdr 0.0.17 (39904e09941046dab61e6e35fc89e31bf2dea1cd)
xdr next (65afa63b7f52c898143ebbe9541ef91fcf290ade)

What did you do?

❯ soroban lab token wrap --asset ABC:GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF

What did you expect to see?

I expect the Stellar Asset contract to be deployed resulting in a contract address being outputted.

For example:

CBMLAIHYS74DMIS5PXB5SH3KL2N3TRHU5IEYNLDINFPNX5Y3ERMWLANJ

What did you see instead?

error: xdr processing error: xdr value invalid

Further details

The same command works with the RPC, so this issue appears to be isolated to the sandbox variation.

For example:

❯ soroban config network add --rpc-url http://localhost:8000/soroban/rpc --network-passphrase 'Standalone Network ; February 2017' local
❯ soroban config identity add --secret-key me
❯ soroban lab token wrap --network local --source me --asset ABC:GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF
CBMLAIHYS74DMIS5PXB5SH3KL2N3TRHU5IEYNLDINFPNX5Y3ERMWLANJ

@tsachiherman tsachiherman added this to the Soroban Testnet Release milestone Sep 7, 2023
@tsachiherman tsachiherman linked an issue Sep 7, 2023 that may be closed by this pull request
soroban-cli: wrap token fails with valid inputs in sandbox mode #930
Closed
@tsachiherman tsachiherman changed the title update soroban-cli: wrap token fails with valid inputs in sandbox mode Sep 7, 2023
@tsachiherman tsachiherman self-assigned this Sep 7, 2023
@tsachiherman tsachiherman marked this pull request as ready for review September 7, 2023 17:31
leighmcculloch
leighmcculloch approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tsachiherman tsachiherman enabled auto-merge (squash) September 7, 2023 17:41
@tsachiherman tsachiherman merged commit 0a020c7 into main Sep 7, 2023
19 of 20 checks passed
@tsachiherman tsachiherman deleted the tsachi/fixwrap branch September 7, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighmcculloch leighmcculloch leighmcculloch approved these changes

Assignees

@tsachiherman tsachiherman

Labels
soroban-scrum
Projects
Platform Scrum
Status: Done
Milestone
Soroban Testnet Release
Development

Successfully merging this pull request may close these issues.

soroban-cli: wrap token fails with valid inputs in sandbox mode
2 participants
@tsachiherman @leighmcculloch